From a3d4d4f2e6743f7fba90147d8cc7a37ecbcdfd83 Mon Sep 17 00:00:00 2001 From: amitsetty Date: Fri, 2 Sep 2022 08:32:49 +0300 Subject: [PATCH] Fix tests --- .../src/opentelemetry/instrumentation/pymongo/__init__.py | 2 +- .../tests/test_pymongo.py | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/instrumentation/opentelemetry-instrumentation-pymongo/src/opentelemetry/instrumentation/pymongo/__init__.py b/instrumentation/opentelemetry-instrumentation-pymongo/src/opentelemetry/instrumentation/pymongo/__init__.py index 151f0dde5b..91cd81aab3 100644 --- a/instrumentation/opentelemetry-instrumentation-pymongo/src/opentelemetry/instrumentation/pymongo/__init__.py +++ b/instrumentation/opentelemetry-instrumentation-pymongo/src/opentelemetry/instrumentation/pymongo/__init__.py @@ -122,7 +122,7 @@ def started(self, event: monitoring.CommandStartedEvent): return command = event.command.get(event.command_name, "") name = event.database_name - name += "." + event.command_name + name += "." + event.command_name statement = event.command_name if command: statement += " " + str(command) diff --git a/instrumentation/opentelemetry-instrumentation-pymongo/tests/test_pymongo.py b/instrumentation/opentelemetry-instrumentation-pymongo/tests/test_pymongo.py index ef3734c596..15a5a0be0b 100644 --- a/instrumentation/opentelemetry-instrumentation-pymongo/tests/test_pymongo.py +++ b/instrumentation/opentelemetry-instrumentation-pymongo/tests/test_pymongo.py @@ -40,7 +40,6 @@ def test_pymongo_instrumentor(self): ) with patch: PymongoInstrumentor().instrument() - self.assertTrue(mock_register.called) def test_started(self): @@ -59,7 +58,7 @@ def test_started(self): # pylint: disable=protected-access span = command_tracer._pop_span(mock_event) self.assertIs(span.kind, trace_api.SpanKind.CLIENT) - self.assertEqual(span.name, "command_name.find") + self.assertEqual(span.name, "database_name.command_name") self.assertEqual(span.attributes[SpanAttributes.DB_SYSTEM], "mongodb") self.assertEqual( span.attributes[SpanAttributes.DB_NAME], "database_name" @@ -189,8 +188,7 @@ def test_int_command(self): self.assertEqual(len(spans_list), 1) span = spans_list[0] - - self.assertEqual(span.name, "command_name.123") + self.assertEqual(span.name, "database_name.command_name") class MockCommand: