Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip leading comments from SQL queries when generating the span name. #1433

Closed
rogersd opened this issue Nov 9, 2022 · 0 comments · Fixed by #1434
Closed

Strip leading comments from SQL queries when generating the span name. #1433

rogersd opened this issue Nov 9, 2022 · 0 comments · Fixed by #1434
Labels
feature-request

Comments

@rogersd
Copy link
Contributor

rogersd commented Nov 9, 2022 •
edited
Loading

Currently an SQL statement that begins with a comment, such as

/* Get foo from bar */ SELECT foo FROM bar

Will have span.name set to /*, which makes it harder to tell what's going on in the waterfall view for a request.

Instead, the leading comment should be removed so that the operation type is used instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
1 participant
@rogersd