Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentations do not use tracer_provider argument to create a tracer instances #401

Open
srikanthccv opened this issue Apr 4, 2021 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed triaged

Comments

@srikanthccv
Copy link
Member

Users can optionally pass an instance of TracerProvider to SomeInstrumentator.instrument(tracer_provider=...). Instrumentations should use this tracer_provider and fall back to global tracer provider if not given. As of now some instrumentations directly use global tracer provider which is not expected because providers can have different configuration such as Resource.

@github-actions
Copy link

github-actions bot commented May 5, 2021

This issue was marked stale due to lack of activity. It will be closed in 30 days.

@lzchen lzchen added triaged good first issue Good for newcomers help wanted Extra attention is needed and removed backlog labels May 5, 2021
@lzchen
Copy link
Contributor

lzchen commented May 5, 2021

Remaining instrumentations: sklearn, pyramid and (perhaps) the logging instrumentation.

@srikanthccv srikanthccv removed their assignment May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed triaged
Projects
None yet
Development

No branches or pull requests

2 participants