Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-instrumentation-django cannot support Dajngo 1.11 #512

Closed
unique0lai opened this issue May 26, 2021 · 4 comments
Closed

opentelemetry-instrumentation-django cannot support Dajngo 1.11 #512

unique0lai opened this issue May 26, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@unique0lai
Copy link

https://docs.djangoproject.com/en/2.2/ref/urlresolvers/#django.urls.ResolverMatch.route
"route" is not exists before Django 2.2

@daneah
Copy link

daneah commented May 26, 2021

Django 1.11 ended mainstream support 3 years ago, and LTS support ended just over 1 year ago (handy table). I'd guess it's is a bit too old to support at this point?

That said, it would be good to understand from a design perspective the intent for support planned for other frameworks. I looked in the contribution guidelines and READMEs but didn't find anything too obvious!

@ocelotl
Copy link
Contributor

ocelotl commented May 26, 2021

Django 1.11 ended mainstream support 3 years ago, and LTS support ended just over 1 year ago (handy table). I'd guess it's is a bit too old to support at this point?

That said, it would be good to understand from a design perspective the intent for support planned for other frameworks. I looked in the contribution guidelines and READMEs but didn't find anything too obvious!

We haven't made a decision on which versions of which frameworks are to be supported. Nevertheless, this may no longer be relevant after #475 is merged.

@unique0lai
Copy link
Author

unique0lai commented May 30, 2021

OK. If it can not support Django 1.11, the install_required should be update. The supported Django version should be clear.

@owais
Copy link
Contributor

owais commented Jun 1, 2021

Django 1.11 ended mainstream support 3 years ago, and LTS support ended just over 1 year ago (handy table). I'd guess it's is a bit too old to support at this point?
That said, it would be good to understand from a design perspective the intent for support planned for other frameworks. I looked in the contribution guidelines and READMEs but didn't find anything too obvious!

Like @ocelotl said, we don't have any guidelines yet but in general I think we wouldn't add support for very old versions but if we already support a version, I don't think we'd drop it as the library is EOLed unless it becomes too painful to support very old and latest versions at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants