-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opentelemetry-instrumentation-django cannot support Dajngo 1.11 #512
Comments
Django 1.11 ended mainstream support 3 years ago, and LTS support ended just over 1 year ago (handy table). I'd guess it's is a bit too old to support at this point? That said, it would be good to understand from a design perspective the intent for support planned for other frameworks. I looked in the contribution guidelines and READMEs but didn't find anything too obvious! |
We haven't made a decision on which versions of which frameworks are to be supported. Nevertheless, this may no longer be relevant after #475 is merged. |
OK. If it can not support Django 1.11, the install_required should be update. The supported Django version should be clear. |
Like @ocelotl said, we don't have any guidelines yet but in general I think we wouldn't add support for very old versions but if we already support a version, I don't think we'd drop it as the library is EOLed unless it becomes too painful to support very old and latest versions at the same time. |
opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware.py
Line 174 in 2bd6053
https://docs.djangoproject.com/en/2.2/ref/urlresolvers/#django.urls.ResolverMatch.route
"route" is not exists before Django 2.2
The text was updated successfully, but these errors were encountered: