Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jaeger exporter: Resource to Process mapping #1436

Closed
codeboten opened this issue Nov 30, 2020 · 3 comments
Closed

Jaeger exporter: Resource to Process mapping #1436

codeboten opened this issue Nov 30, 2020 · 3 comments
Labels
1.0.0rc2 release candidate 2 for tracing GA exporters good first issue Good first issue help wanted release:required-for-ga To be resolved before GA release

Comments

@codeboten
Copy link
Contributor

As per spec:

OpenTelemetry resources MUST be mapped to Jaeger's Span.Process tags. Multiple resources can exist for a single process and exporters need to handle this case accordingly.

See more details: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk_exporters/jaeger.md#resource
@codeboten codeboten added good first issue Good first issue exporters help wanted release:required-for-ga To be resolved before GA release 1.0.0rc2 release candidate 2 for tracing GA labels Nov 30, 2020
@srikanthccv
Copy link
Member

@codeboten I believe this is already addressed here as a part of #1471. Jaeger thrift model definition for Span doesn't have any Process so I think this can be marked as completed.

@lzchen
Copy link
Contributor

lzchen commented Jan 27, 2021

@codeboten @lonewolf3739 Is this issue resolved?

@codeboten
Copy link
Contributor Author

@lzchen 👍 LGTM

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0.0rc2 release candidate 2 for tracing GA exporters good first issue Good first issue help wanted release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codeboten @lzchen @srikanthccv