Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Jaeger exporter status code to error tag #1474

Closed
lzchen opened this issue Dec 14, 2020 · 2 comments · Fixed by #1488
Closed

Update Jaeger exporter status code to error tag #1474

lzchen opened this issue Dec 14, 2020 · 2 comments · Fixed by #1488
Assignees
@srikanthccv
Labels
exporters good first issue Good first issue release:required-for-ga To be resolved before GA release

Comments

@lzchen
Copy link
Contributor

lzchen commented Dec 14, 2020 •
edited
Loading

From the specs Jaeger exporter tags for status code must be the string representation of the status code enum.

Related:
#1402
@lzchen lzchen added bug Something isn't working exporters release:required-for-ga To be resolved before GA release good first issue Good first issue and removed bug Something isn't working labels Dec 14, 2020
@srikanthccv
Copy link
Member

@lzchen specs is linked to open-census probably you meant this open-telemetry/opentelemetry-specification#1257. So with this spec change tag type should be string (OK, ERROR) instead of number in exporter?

@lzchen
Copy link
Contributor Author

lzchen commented Dec 16, 2020

@lonewolf3739
Oops, my bad, fixed. Yes you are correct.

@srikanthccv srikanthccv mentioned this issue Dec 16, 2020
Merged
@lzchen lzchen mentioned this issue Jan 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srikanthccv srikanthccv

Labels
exporters good first issue Good first issue release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Jaeger exporter status code srikanthccv/opentelemetry-python
2 participants
@lzchen @srikanthccv