You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Recommendation is to change the doc to something like
name: The name of the instrumenting module, package, module or class.
For log sources which define a logger name (e.g. logging.Logger.name)
the Logger Name should be recorded as the instrumentation scope name.
Attributes are not documented as parameter in get_logger API
LoggerProvider
docs are based on old spec language and should be updated.Specifically:
Identifying parameters - different loggers should be returned if parameters are different
opentelemetry-python/opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py
Lines 165 to 166 in 59d6754
was changed recently (Define attributes equality and make all fields as identifying for Tracer, Meter, Logger, EventLogger opentelemetry-specification#4161) to make all parameters identifiable and guarantee that different loggers are returned.
the implementation is already compliant, it's just a doc issue.
Logger name should be used as scope name
opentelemetry-python/opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py
Lines 172 to 176 in 59d6754
Spec language
https://github.com/open-telemetry/opentelemetry-specification/blob/881f364cb5f64f7f276fbe2e69dbc5f2a0d4e76e/specification/logs/api.md#get-a-logger
Recommendation is to change the doc to something like
Attributes are not documented as parameter in
get_logger
APIopentelemetry-python/opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py
Lines 187 to 188 in 59d6754
Part of open-telemetry/community#1751
The text was updated successfully, but these errors were encountered: