Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext/psycopg2: Implement BaseInstrumentor interface #633

Closed
codeboten opened this issue May 1, 2020 · 2 comments · Fixed by #694
Closed

ext/psycopg2: Implement BaseInstrumentor interface #633

codeboten opened this issue May 1, 2020 · 2 comments · Fixed by #694
Assignees
Labels
good first issue Good first issue help wanted instrumentation Related to the instrumentation of third party libraries or frameworks

Comments

@codeboten
Copy link
Contributor

In order for users of psycopg2 to take advantage of opentelemetry-auto-instrumentation, the following needs to happen:

  1. add a class implementing the BaseInstrumentor interface. here is an example for ext/pymysql
  2. an entrypoint must be added to setup.cfg. here is an example for ext/pymsql
  3. tests added to ensure the new instrumentor behaves as expected. here is an example for ext/pymysql
  4. the documentation must be updated to reflect the new method of instrumenting psycopg2 applications
  5. CHANGELOG.md must be updated
@codeboten codeboten added good first issue Good first issue help wanted instrumentation Related to the instrumentation of third party libraries or frameworks labels May 1, 2020
@cnnradams
Copy link
Member

@codeboten can this be assigned to me?

@codeboten
Copy link
Contributor Author

All yours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good first issue help wanted instrumentation Related to the instrumentation of third party libraries or frameworks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants