SQLite3 Instrumentation #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnnradams
force-pushed
the
sqlite3-instrumentation
branch
2 times, most recently
from
11e94e5 to
c906159
Compare
cnnradams
force-pushed
the
sqlite3-instrumentation
branch
from
c906159 to
ece7b41
Compare
lzchen
reviewed
May 21, 2020
|
|
||
| cnx = sqlite3.connect('example.db') | ||
| cursor = cnx.cursor() | ||
| cursor.execute("INSERT INTO test (testField) VALUES (123)" |
lzchen
reviewed
May 21, 2020
tox.ini
Outdated
| @@ -192,6 +197,7 @@ commands_pre = | |||
| flask,django: pip install {toxinidir}/opentelemetry-auto-instrumentation | |||
| flask: pip install {toxinidir}/ext/opentelemetry-ext-flask[test] | |||
|
|
|||
| dbapi: pip install {toxinidir}/opentelemetry-auto-instrumentation | |||
There was a problem hiding this comment.
Do you need the auto-instrumentation module for this test suite?
lzchen
approved these changes
May 21, 2020
hectorhdzg
approved these changes
May 21, 2020
@cnnradams if that's the case, can you file a ticket and pick this up as a followup PR? Would love to pay down this debt as we go along. Regarding where to put this code, I'm open to either a more specific shared package (e.g. opentelemetry-instrumentation-dbapi), or a mega-shared package for all shared utils across all instrumentations. @codeboten @c24t for their thoughts. In the meantime I'll merge this PR. Thanks! |
6 tasks
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
test: fix and add tests closes open-telemetry#642 Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds instrumentation for python sqlite3 library.
There is a lot of repeat code in the SQLite3Instrumentor (shared with every other DBAPI instrumentor), it could possibly be pulled out into a DBAPIInstrumentor that can be subclassed in this PR or another.
Resolves #683