Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs #1312

Merged
merged 5 commits into from
Nov 2, 2020
Merged

Update docs #1312

merged 5 commits into from
Nov 2, 2020

Conversation

srikanthccv
Copy link
Member

Description

Update README, docs and examples. Probably missed in #953.

Type of change

  • This change requires a documentation update

How Has This Been Tested?

  • tox -e docs

Checklist:

  • Documentation has been updated

@srikanthccv srikanthccv requested review from a team, codeboten and ocelotl and removed request for a team October 31, 2020 15:06
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 31, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

lzchen
lzchen approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

codeboten
codeboten suggested changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these, just a one request for change.

exporter/opentelemetry-exporter-zipkin/setup.cfg Outdated Show resolved Hide resolved
@srikanthccv @codeboten
Update exporter/opentelemetry-exporter-zipkin/setup.cfg
aee461b 
Co-authored-by: alrex <alrex.boten@gmail.com>
@codeboten codeboten merged commit 4680594 into open-telemetry:master Nov 2, 2020
@srikanthccv srikanthccv deleted the fix-docs branch December 6, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@codeboten codeboten codeboten approved these changes

@ocelotl ocelotl Awaiting requested review from ocelotl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srikanthccv @codeboten @lzchen