Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Attribute rather than boundattribute in logrecord repr #3567

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Use Attribute rather than boundattribute in logrecord repr #3567

merged 2 commits into from
Feb 16, 2024

Conversation

pegasas
Copy link
Contributor

@pegasas pegasas commented Dec 3, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #3547

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@pegasas pegasas requested a review from a team December 3, 2023 05:58
@srikanthccv
Copy link
Member

This is not the correct fix. We should continue to use bounded attributes but the repr and string methods should be fixed.

@pegasas
Copy link
Contributor Author

pegasas commented Jan 1, 2024

This is not the correct fix. We should continue to use bounded attributes but the repr and string methods should be fixed.

Thanks for guidance.
It seems it is related to __repr__ method.

@ocelotl
Copy link
Contributor

ocelotl commented Feb 13, 2024

@srikanthccv PTAL, I think @pegasas has added a fix for your comment.

@srikanthccv srikanthccv changed the title Use Attribute rather than boundattribute in logrecord Use Attribute rather than boundattribute in logrecord repr Feb 16, 2024
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix lint

@pegasas
Copy link
Contributor Author

pegasas commented Feb 16, 2024

Please fix lint

Thanks for calling out.
Done.

@ocelotl ocelotl merged commit 2b9dcfc into open-telemetry:main Feb 16, 2024
232 checks passed
@pegasas pegasas deleted the issues3547 branch February 17, 2024 01:49
@hirotasoshu
Copy link
Contributor

@pegasas @srikanthccv @ocelotl I think changelog in this PR is misleading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console exporter: inconsistent "resource" representation
4 participants