Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add missing Resource SchemaURL in otlp exporters #3652

Conversation

hirotasoshu
Copy link
Contributor

@hirotasoshu hirotasoshu commented Jan 28, 2024

Description

Schema URL was missed in Resources when using OTLP exporters
The specified issue says only about the logs, but in fact it was missed in the traces and in the metrics
Fixes #3553

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Check specified issue for example

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added (actually not added, but updated)
  • Documentation has been updated

@hirotasoshu hirotasoshu requested a review from a team January 28, 2024 16:04
Copy link

linux-foundation-easycla bot commented Jan 28, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@hirotasoshu hirotasoshu changed the title Add missing Resource SchemaURL in otlp exporters Fix: Add missing Resource SchemaURL in otlp exporters Jan 28, 2024
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ocelotl ocelotl force-pushed the add_missing_resource_schema_url_in_otlp_exporters branch from e71ef8b to e92a05b Compare February 10, 2024 04:57
@ocelotl ocelotl enabled auto-merge (squash) February 10, 2024 04:57
auto-merge was automatically disabled February 10, 2024 05:02

Pull Request is not mergeable

@ocelotl ocelotl merged commit e98af82 into open-telemetry:main Feb 10, 2024
270 checks passed
@hirotasoshu hirotasoshu deleted the add_missing_resource_schema_url_in_otlp_exporters branch February 21, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs: SchemaURL is missing in the Resource when using OTLP exporter
3 participants