Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update opentracing and opencesus docs examples to not use JaegerExporter #4023

Merged
merged 11 commits into from
Jul 9, 2024
Merged

Update opentracing and opencesus docs examples to not use JaegerExporter #4023

merged 11 commits into from
Jul 9, 2024

Conversation

arunk1988
Copy link
Contributor

@arunk1988 arunk1988 commented Jul 4, 2024 •
edited
Loading

Description

Fixes #3970

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@arunk1988 arunk1988 requested a review from a team July 4, 2024 04:24
@arunk1988 arunk1988 changed the title Update opentracing and opencesus docs examples to not use JaegerExporter #3970 Update opentracing and opencesus docs examples to not use JaegerExporter Jul 4, 2024
@arunk1988 @tammy-baylis-swi
Update docs/examples/opencensus-shim/app.py
e1f70d3 
Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com>
emdneto
emdneto reviewed Jul 4, 2024
View reviewed changes
test Outdated Show resolved Hide resolved
arunk1988 and others added 2 commits July 5, 2024 06:53
@arunk1988
Delete test
13d0dd9
@arunk1988 @tammy-baylis-swi
Update docs/examples/opentracing/main.py
69a9b96 
Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com>
tammy-baylis-swi
tammy-baylis-swi approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making adjustments. Lgtm, we'll need Maintainer eyes as well. Edit: @xrmx I've added this to the board for next sig meeting.

@tammy-baylis-swi
Copy link
Contributor

Hi again @arunk1988 , please could you add a line to the changelog describing your changes too.

arunk1988 and others added 2 commits July 5, 2024 23:47
@arunk1988 @tammy-baylis-swi
Update docs/examples/opencensus-shim/app.py
dd1419f 
Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com>
@arunk1988 @tammy-baylis-swi
Update docs/examples/opentracing/main.py
606e3de 
Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com>
@arunk1988
Copy link
Contributor Author

Hi @tammy-baylis-swi, required changes are done.

@tammy-baylis-swi
Copy link
Contributor

Noting that changelog is being updated in #4027

emdneto
emdneto reviewed Jul 5, 2024
View reviewed changes
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we wrong merged #4027 . The changelog should be present in the PR itself I think. Well, can we have skip changelog here then?

zhihali
zhihali approved these changes Jul 6, 2024
View reviewed changes
Copy link
Contributor

@zhihali zhihali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, but I suggest tick the boxs(what change you did, how did you test the code) at your PR description. That would be helpful to approvers and reviewers. And if changelog is not updated, pls commit it in this PR, creating a new PR would be confusing…

@arunk1988
Copy link
Contributor Author

arunk1988 commented Jul 7, 2024 •
edited
Loading

understood, sorry for the confusion...thanks for the review @Charlie-lizhihan. I see the changelog update has been merged, should i still commit the changelog update in this PR

@lzchen lzchen added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 8, 2024
@arunk1988
Copy link
Contributor Author

I see the approval from all the reviewers, anything required from my end to get this PR merged ?

@xrmx
Copy link
Contributor

xrmx commented Jul 9, 2024

@arunk1988 just having a bit of patience 😅

@lzchen lzchen merged commit b596734 into open-telemetry:main Jul 9, 2024
269 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tammy-baylis-swi tammy-baylis-swi tammy-baylis-swi approved these changes

@zhihali zhihali zhihali approved these changes

@lzchen lzchen lzchen approved these changes

@emdneto emdneto emdneto approved these changes

@xrmx xrmx xrmx approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update opentracing and opencesus docs examples to not use JaegerExporter
6 participants
@arunk1988 @tammy-baylis-swi @xrmx @emdneto @lzchen @zhihali