Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align process command arguments to spec defenition #4032

Merged

Conversation

tamirdavid
Copy link
Contributor

Description

According to the process attributes within the spec of semconv process.command_args should be "All the command arguments (including the command/executable itself)".
In the current implementation, it is handling all command arguments without the command itself.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit Test

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added - unit test adjusted
  • Documentation has been updated

@tamirdavid tamirdavid requested a review from a team July 8, 2024 13:16
Copy link

linux-foundation-easycla bot commented Jul 8, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a changelog entry

@tamirdavid tamirdavid force-pushed the align-proc-args-to-spec-definition branch from dcc61da to 46f614b Compare July 9, 2024 06:42
@tamirdavid1
Copy link

added

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
CHANGELOG.md Outdated Show resolved Hide resolved
@tamirdavid
Copy link
Contributor Author

Hey guys,
someone can please help me run the tests again and merge it?
thanks

@lzchen lzchen merged commit eb28711 into open-telemetry:main Jul 11, 2024
269 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants