-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: align process command arguments to spec defenition #4032
Merged
lzchen
merged 8 commits into
open-telemetry:main
from
tamirdavid:align-proc-args-to-spec-definition
Jul 11, 2024
Merged
fix: align process command arguments to spec defenition #4032
lzchen
merged 8 commits into
open-telemetry:main
from
tamirdavid:align-proc-args-to-spec-definition
Jul 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emdneto
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a changelog entry
tamirdavid
force-pushed
the
align-proc-args-to-spec-definition
branch
from
July 9, 2024 06:42
dcc61da
to
46f614b
Compare
added |
xrmx
approved these changes
Jul 9, 2024
lzchen
approved these changes
Jul 9, 2024
emdneto
reviewed
Jul 9, 2024
emdneto
approved these changes
Jul 9, 2024
Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
xrmx
reviewed
Jul 10, 2024
Hey guys, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the process attributes within the spec of semconv
process.command_args
should be "All the command arguments (including the command/executable itself)".In the current implementation, it is handling all command arguments without the command itself.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: