Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExponentialHistograms to data types supported #4134

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Aug 19, 2024

ExponentialHistogram support was added long time ago #2964, but the types were not properly exported and some linters will complain about this.

This PR exports the ExponentialHistogram and ExponentialHistogramDataPoint and marks the Metric.data to support this new types.

@bogdandrutu bogdandrutu requested a review from a team August 19, 2024 18:25
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we probably just missed it earlier.

Can you just add something to the PR description or a linked issue with context?

@bogdandrutu bogdandrutu force-pushed the addexponentialhisto branch 2 times, most recently from d9e6538 to 15764d6 Compare August 19, 2024 20:35
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@lzchen lzchen merged commit 110bb73 into open-telemetry:main Aug 20, 2024
376 checks passed
hyoinandout pushed a commit to hyoinandout/opentelemetry-python that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants