Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opentelemetry-sdk: setup EventLogger when initializing logging #4270

Merged
merged 1 commit into from
Nov 12, 2024
Merged

opentelemetry-sdk: setup EventLogger when initializing logging #4270

merged 1 commit into from
Nov 12, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Nov 12, 2024

Description

Setup the EventLogger when OTEL_PYTHON_LOGGING_AUTO_INSTRUMENTATION_ENABLED is set so that log events works out of the box with autoinstrumentation.

Fixes #4269

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e py310-test-opentelemetry-sdk

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx requested a review from a team as a code owner November 12, 2024 09:15
@lzchen lzchen merged commit a119185 into open-telemetry:main Nov 12, 2024
353 checks passed
@aabmass aabmass mentioned this pull request Nov 14, 2024
Closed
6 tasks
aabmass pushed a commit to aabmass/opentelemetry-python that referenced this pull request Nov 14, 2024
@xrmx @aabmass
opentelemetry-sdk: setup EventLogger when initializing logging (open-…
7def515 
…telemetry#4270)
@aabmass aabmass mentioned this pull request Nov 14, 2024
Merged
aabmass pushed a commit to aabmass/opentelemetry-python that referenced this pull request Nov 14, 2024
@xrmx @aabmass
opentelemetry-sdk: setup EventLogger when initializing logging (open-…
2cc8161 
…telemetry#4270)
aabmass added a commit that referenced this pull request Nov 15, 2024
@aabmass @xrmx
[release/v1.28.x-0.49bx] opentelemetry-sdk: setup EventLogger when in…
ea809eb 
…itializing logging (#4270) (#4283)

* opentelemetry-sdk: setup EventLogger when initializing logging (#4270)

* Move cherry-picked changelog entry to Unreleased section

---------

Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
@aabmass aabmass mentioned this pull request Nov 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable by default or support ENV based configuration of EventLoggerProvider
2 participants
@xrmx @lzchen