Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrib repo #1014

Closed
cijothomas opened this issue Mar 30, 2023 · 3 comments
Closed

Contrib repo #1014

cijothomas opened this issue Mar 30, 2023 · 3 comments

Comments

@cijothomas
Copy link
Member

cijothomas commented Mar 30, 2023

Currently all the components - OTel spec components (API/SDK/Exporter), instrumentations, vendor specific components are all in the same repo (this repo). Given the general recommendation from OpenTelemetry is to host vendor specific components in a separate "-contrib" repo, could we consider spinning up a new contrib repo, and start moving the vendor specific components there?

Most other OTel languages has started with single repo (just like OTel-Rust), and then eventually spun off a contrib repo, and moved components there. There is some logistics involved in that, but given it is something that'll be needed eventually, it'd probably be a good idea to start now when there are only few components that require "lift & shift".

(My colleagues are planning to contribute few components, mostly Exporters to OS native tracing mechanisms like Windows ETW Exporter, Linux user_events exporter etc. It'd be nice if we can make it to the contrib repo, but we are okay to host it here as well if there are no concerns.)

Note: I can help as needed with some logistics. (Have gone through this exercise in OTel .NET, OTel .NET Contrib spin off)

@TommyCpp
Copy link
Contributor

We can also experient to add different owner in contrib repo for different component

@cijothomas
Copy link
Member Author

We can also experient to add different owner in contrib repo for different component

Its been a challenge so far... The github's codeowner model won't work unless the individual component owner also has write access to the repo (i.e they must be at least an approver.)... We used a custom plugin to achieve similar goals (https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/.github/component_owners.yml#L1), but that'd also work only if the owner is at least a member of the OpenTelemetry organization! Anyway, it should be possible to manage this, given many other SIGs are managing it. Especially the Collector-Contrib repo which has the highest number of components in contrib.

@hdost
Copy link
Contributor

hdost commented Apr 6, 2023

This is a duplicate issue #841

Continuing conversation there.

@hdost hdost closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants