Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpanContext should implement serde::Serialize, Deserialize #1074

Open
shaun-cox opened this issue May 23, 2023 · 2 comments
Open

SpanContext should implement serde::Serialize, Deserialize #1074

shaun-cox opened this issue May 23, 2023 · 2 comments
Labels
A-trace Area: issues related to tracing enhancement New feature or request triage:todo Needs to be traiged.
Milestone
Tracing API Stable

Comments

@shaun-cox
Copy link
Contributor

Per Rust API Guidelines for Interoperability I think SpanContext should implement serde::Serialize and Deserialize.

I'll see about making this contribution myself, but wanted to open the issue in case there is disagreement with the approach. (From my understanding, we want to prefer idiomatic usage of the language features for the API.) This will help me and others in building domain-specific propagators ala .with_remote_span_context.
This was referenced May 23, 2023
Closed
Closed
@djc
Copy link
Contributor

djc commented May 24, 2023

Closing this in favor of discussion on #1075.

@djc djc closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2023
@djc djc reopened this May 24, 2023
@djc
Copy link
Contributor

djc commented May 24, 2023

Sorry, I missed that #1075 is the PR for fixing this.

@TommyCpp TommyCpp added enhancement New feature or request A-trace Area: issues related to tracing labels May 25, 2023
@hdost hdost added this to the Tracing API Stable milestone Feb 21, 2024
@hdost hdost added the triage:todo Needs to be traiged. label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-trace Area: issues related to tracing enhancement New feature or request triage:todo Needs to be traiged.
Projects
None yet
Milestone
Tracing API Stable
Development

Successfully merging a pull request may close this issue.

Optional serde support for SpanContext
4 participants
@djc @hdost @TommyCpp @shaun-cox