-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop include_trace_context parameter from Logs API/SDK #1133
Drop include_trace_context parameter from Logs API/SDK #1133
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1133 +/- ##
=====================================
Coverage 49.3% 49.4%
=====================================
Files 175 175
Lines 20470 20434 -36
=====================================
- Hits 10101 10100 -1
+ Misses 10369 10334 -35
☔ View full report in Codecov by Sentry. |
Co-authored-by: Leighton Chen <lechen@microsoft.com>
let ctx = Context::current(); | ||
if ctx.has_active_span() { | ||
let span = ctx.span(); | ||
record.trace_context = Some(span.span_context().into()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we merged #1140. Maybe use map_current
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have resolved the merge conflicts now, and using map_current
for active context.
Fixes #1132
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes