Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opentelemetry_api should not depend on futures_channel #1201

Closed
shaun-cox opened this issue Aug 10, 2023 · 2 comments · Fixed by #1229
Closed

opentelemetry_api should not depend on futures_channel #1201

shaun-cox opened this issue Aug 10, 2023 · 2 comments · Fixed by #1229

Comments

@shaun-cox
Copy link
Contributor

opentelemetry_api depends on futures_channel simply to convert some of its error types into TraceError or LogError.

I think this was done because opentelemetry_sdk happens to use this channel type in its implementation.

I don't think the API crate should depend on futures_channel just for this, and instead would like to move the conversions into the SDK crate instead.
@djc
Copy link
Contributor

djc commented Aug 10, 2023

Makes sense to me.

@cijothomas
Copy link
Member

#1042 similar.

@shaun-cox shaun-cox mentioned this issue Aug 24, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed futures-channel from opentelemetry dependencies shaun-cox/opentelemetry-rust
3 participants
@djc @cijothomas @shaun-cox