Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BatchLogProcessor without async runtime. #1943

Open
lalitb opened this issue Jul 17, 2024 · 0 comments
Open

Support BatchLogProcessor without async runtime. #1943

lalitb opened this issue Jul 17, 2024 · 0 comments
Assignees

Comments

@lalitb
Copy link
Member

lalitb commented Jul 17, 2024

More focused issue for logs (picked from #1437).

While the ideal approach would be to implement a custom asynchronous runtime (see #1506), which is currently a work in progress, an alternative solution could be to use a dedicated thread for uploading logs after reading from the queue. This method is commonly used in other language implementations.

C++: https://github.com/open-telemetry/opentelemetry-cpp/blob/d8ae09e53d6988a063364c86a8362053432a3f9f/sdk/src/logs/batch_log_record_processor.cc#L66

.Net: https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry/BatchExportProcessor.cs

It seems .Net also has a concept of optionally using a shared pool for LogRecord, will create a separate issue to track this optimization.

@lalitb lalitb self-assigned this Jul 17, 2024
@lalitb lalitb added this to the Logging SDK Stable milestone Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant