Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Temporality Selector #2099

Closed
cijothomas opened this issue Sep 11, 2024 · 1 comment
Closed

Cleanup Temporality Selector #2099

cijothomas opened this issue Sep 11, 2024 · 1 comment
Assignees
@cijothomas
Labels
A-metrics Area: issues related to metrics
Milestone
0.27

Comments

@cijothomas
Copy link
Member

Similar to #2085, we should remove this trait/implementations from public API. The exporters can offer https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-otlp/src/metric.rs#L172-L180 with_delta method to switch temporality to delta from the default cumulative. This reduces a lot of unnecessary code in metrics sdk without significantly losing any functionality. OTLP Exporter only allows 3 options : https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk_exporters/otlp.md

(We can ofcourse add with_lowmemory_temporality if needed)
@cijothomas cijothomas added the A-metrics Area: issues related to metrics label Sep 11, 2024
@cijothomas cijothomas added this to the Metrics beta release milestone Sep 11, 2024
@cijothomas cijothomas modified the milestones: Metrics beta release, 0.27 Oct 2, 2024
@cijothomas cijothomas mentioned this issue Oct 17, 2024
Merged
4 tasks
@cijothomas cijothomas self-assigned this Oct 23, 2024
@cijothomas
Copy link
Member Author

Take care by #2217 closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cijothomas cijothomas

Labels
A-metrics Area: issues related to metrics
Projects
None yet
Milestone
0.27
Development

No branches or pull requests
1 participant
@cijothomas