Skip to content

Commit

Permalink
Match Headers
Browse files Browse the repository at this point in the history
  • Loading branch information
hughesjj committed Sep 23, 2022
1 parent 3d89d66 commit 853511c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
5 changes: 3 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ MISSPELL = $(TOOLS_DIR)/$(MISSPELL_BINARY)

# see https://github.com/open-telemetry/build-tools/releases for semconvgen updates
# Keep links in semantic_conventions/README.md and .vscode/settings.json in sync!
SEMCONVGEN_VERSION=0.14.0
#SEMCONVGEN_VERSION=0.14.0
SEMCONVGEN_VERSION=latest

# TODO: add `yamllint` step to `all` after making sure it works on Mac.
.PHONY: all
Expand Down Expand Up @@ -80,7 +81,7 @@ table-generation:
# Check if current markdown tables differ from the ones that would be generated from YAML definitions
.PHONY: table-check
table-check:
docker run --rm -v $(PWD)/semantic_conventions:/source -v $(PWD)/specification:/spec \
docker run --rm -it -v $(PWD)/semantic_conventions:/source -v $(PWD)/specification:/spec \
otel/semconvgen:$(SEMCONVGEN_VERSION) -f /source markdown -md /spec --md-check

.PHONY: schema-check
Expand Down
6 changes: 3 additions & 3 deletions specification/resource/semantic_conventions/db/redis.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
**Description:** A redis instance

<!-- semconv redis -->
| Attribute | Type | Description | Examples | Required |
| Attribute | Type | Description | Examples | Requirement Level |
|---|---|---|---|---|
| `db.redis.instance` | string | The reported name of the Redis instance. This can be in the form of `{host}:{port}` or any other name provided manually while configuring the instrumentation. If not provided, the default value is the `endpoint` value provided in the configuration. | `localhost:6379`; `product_info_redis` | No |
<!-- endsemconv -->
| `db.redis.instance` | string | The reported name of the Redis instance. This can be in the form of `{host}:{port}` or any other name provided manually while configuring the instrumentation. If not provided, the default value is the `endpoint` value provided in the configuration. | `localhost:6379`; `product_info_redis` | Recommended |
<!-- endsemconv -->

0 comments on commit 853511c

Please sign in to comment.