Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selection of memory mode for Cumulative Metrics export #1200

Closed
carlosalberto opened this issue Nov 6, 2020 · 3 comments
Closed

Allow selection of memory mode for Cumulative Metrics export #1200

carlosalberto opened this issue Nov 6, 2020 · 3 comments
Assignees
Labels
area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory

Comments

@carlosalberto
Copy link
Contributor

When using Cumulative reporting of Metrics, allow selecting whether, upon lack of Metric activity, a) no Metric should be exported or b) Metric should be exported with the last value (gauges) or cumulative value (counters and histograms) - instead of sending an empty Metric (that is, no data points).

This came up in Java as per open-telemetry/opentelemetry-java#1978 as we are sending empty Metrics using Cumulative reporting. See @jmacd's comment

When configuring the SDK for cumulative-reporting-with-memory, it should continue to report the last value (for gauges) and cumulative values (for counters and histograms)... I would argue that this "Memory" behavior is a choice: whether to report no metric or to report an old value, but in either case we should not report an empty Metric.

As mentioned in the related link, OTel Go supports selecting this memory mode.

@carlosalberto carlosalberto added area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory labels Nov 6, 2020
@andrewhsu andrewhsu added priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Nov 6, 2020
@andrewhsu
Copy link
Member

from the issue triage mtg today, discussed this and choosing the default seems required for ga, but allowing customization via config seems appropriate for after ga.

can we have a separate tracking issue for config and we have this one just track the default behaviour?

@andrewhsu
Copy link
Member

assigning to carlos initially to get the issues split up, but can reassign later if more appropriate

@reyang reyang self-assigned this Mar 3, 2021
@reyang reyang added this to the Metrics API/SDK Feature Freeze milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

No branches or pull requests

3 participants