Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Histogram requirements in the Metrics SDK spec #1798

Closed
reyang opened this issue Jul 6, 2021 · 3 comments
Closed

Define Histogram requirements in the Metrics SDK spec #1798

reyang opened this issue Jul 6, 2021 · 3 comments
Assignees
Labels
area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory

Comments

@reyang
Copy link
Member

reyang commented Jul 6, 2021

What are you trying to achieve?

The metrics data model specification has covered Histogram here.

The goal is to have the SDK specification supporting histogram:

  1. What would be the default histogram buckets?
  2. What type of buckets of we support (arbitrary buckets, equal size buckets, exponential buckets, etc.)? If we have exponential buckets, what base (e.g. base 2 or base 10) do we support?
  3. What type of compression format / algorithm do we support (e.g. UDDSketch, etc.)?
  4. Do we allow conversion / interpolation (e.g. convert base 2 buckets to base 10 buckets with potential data loss)?

Some of these topics are being discussed in #1776, and we try to resolve it next week (7/13/2021) - @jmacd FYI.

Related to #1260.

@reyang reyang added the spec:metrics Related to the specification/metrics directory label Jul 6, 2021
@reyang reyang added the area:sdk Related to the SDK label Jul 6, 2021
@reyang
Copy link
Member Author

reyang commented Sep 3, 2021

We've discussed this during the Metrics SIG meetings and decided to move "base 2 exponential histogram" out of the initial stable release scope (which means the metrics SDK spec stable release won't be blocked on base 2 exponential histogram, if we can catch the feature-freeze train we might be able to take it".

@reyang
Copy link
Member Author

reyang commented Sep 3, 2021

@jsuereth I guess this can be closed? Please confirm.

@reyang
Copy link
Member Author

reyang commented Sep 10, 2021

@jsuereth I think this can be marked as done, I'll close it now. If there are still remaining items, feel free to reopen it.

@reyang reyang closed this as completed Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

No branches or pull requests

3 participants