Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify on the term Aggregation #2165

Closed
legendecas opened this issue Nov 24, 2021 · 1 comment
Closed

Clarify on the term Aggregation #2165

legendecas opened this issue Nov 24, 2021 · 1 comment
Assignees
Labels
spec:metrics Related to the specification/metrics directory

Comments

@legendecas
Copy link
Member

What are you trying to achieve?

In the metrics SDK spec, the term Aggregation is declared to "informs the SDK on the ways and means to compute Aggregated Metrics from incoming Instrument Measurements."

Also, there is a pre-defined aggregation DefaultAggregation which acts like the previously defined AggregatorSelector, and SumAggregation and HistogramAggregation etc. that act like previously defined concrete type SumAggregator and HistogramAggregator. With #2153 the term Aggregator will be reserved in the spec, it is still unclear what the Aggregation is capable of: just selecting the aggregation means, or does it also handle the concrete aggregation jobs?

Since views are configured with aggregations, I found that it is confusing on the term Aggregation as it is defined like the selector role but used the term for concrete means to compute aggregated metrics.

@legendecas legendecas added the spec:metrics Related to the specification/metrics directory label Nov 24, 2021
@legendecas
Copy link
Member Author

Continuing the discussion on #2149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

No branches or pull requests

2 participants