Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details on converting exemplars for Prometheus #2369

Closed
anuraaga opened this issue Feb 21, 2022 · 5 comments
Closed

Details on converting exemplars for Prometheus #2369

anuraaga opened this issue Feb 21, 2022 · 5 comments
Assignees

Comments

@anuraaga
Copy link
Contributor

Currently we are missing some details for converting Prometheus exemplars. Some notable questions are

Originally posted by @anuraaga in #2266 (comment)

@irizzant
Copy link

irizzant commented Apr 1, 2022

@anuraaga is there any reason why this is closed?

@anuraaga
Copy link
Contributor Author

anuraaga commented Apr 4, 2022

Hi @irizzant - details were added here

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/datamodel.md#exemplars-1

@hanjm
Copy link
Member

hanjm commented Apr 10, 2022

Hi @anuraaga , I have a question: why the no-histogram type exemplar dropped, the Prometheus exemplar is not limit to only histogram. thank you.

Exemplars
Exemplars on OpenTelemetry Histograms SHOULD be converted to OpenMetrics exemplars. Exemplars on other OpenTelemetry data points MUST be dropped.

@anuraaga
Copy link
Contributor Author

Not sure - @dashpole what do you think?

@dashpole
Copy link
Contributor

I think that statement was based on prometheus/prometheus#9738, which was mistaken to mean only histograms. Based on the openmetrics spec, exemplars can be added to counters in addition to histograms. I'll amend the spec to include support for exemplars from Otel monotonic sums (which are converted to openmetrics counters).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants