Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric instruments: default-enabled clarification #2416

Closed
jmacd opened this issue Mar 15, 2022 · 0 comments · Fixed by #2417
Closed

Metric instruments: default-enabled clarification #2416

jmacd opened this issue Mar 15, 2022 · 0 comments · Fixed by #2417
Assignees
Labels
area:sdk Related to the SDK release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:metrics Related to the specification/metrics directory

Comments

@jmacd
Copy link
Contributor

jmacd commented Mar 15, 2022

What are you trying to achieve?

The review thread for #2404 points to lack of clarity around the statement for what happens when Views are configured and none matches the instrument. See the comment thread here: #2404 (comment)

The original text leaves a lot of room for interpretation, perhaps too much.

   * If the Instrument could not match with any of the registered `View`(s), the
    SDK SHOULD provide a default behavior. The SDK SHOULD also provide a way for
    the user to turn off the default behavior via MeterProvider (which means the
    Instrument will be ignored when there is no match). Individual
    implementations can decide what the default behavior is, and how to turn the
    default behavior off.

Additional context.

Discussed in the 3/15 Spec SIG. One proposal appears to be favored, which would require no new parameters. If instruments are enabled when no View matches, then users can always fill in a match-all expression to disable instruments using Views to achieve the effect of instruments being disabled-by-default.

@jmacd jmacd added the spec:metrics Related to the specification/metrics directory label Mar 15, 2022
@reyang reyang added area:sdk Related to the SDK release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs labels Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants