Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a redis resource #2840

Closed
hughesjj opened this issue Sep 26, 2022 · 3 comments
Closed

Add a redis resource #2840

hughesjj opened this issue Sep 26, 2022 · 3 comments
Assignees
Labels
[label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR spec:resource Related to the specification/resource directory

Comments

@hughesjj
Copy link

What are you trying to achieve?
I want a resource for redis' db.instance.

Additional context.
This is prep work to supporting Redis as a metric (not solely trace as we currently have), but should stand on its own. I'm resurrecting (+fixing) code submitted by manang-splunk@ at the beginning of this year.

Original PR: #2145

@hughesjj hughesjj added the spec:resource Related to the specification/resource directory label Sep 26, 2022
@hughesjj
Copy link
Author

This is my "fixed" version of the redis resource:
Related PR: #2836

To my understanding there's an effort to more formally standardize otel specs, I'm not sure if that affects this PR at all.

I'm also cutting pull requests to build-tools to hopefully give people a better time developing/debugging specifications for anyone interested.

@hughesjj
Copy link
Author

I'll be reaching out to various people from the following PRs who seem to have gone down a similar track

@reyang reyang added the [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR label Oct 7, 2022
@hughesjj
Copy link
Author

Closed due to being not needed, we can continue use the existing file specified in trace for now. Will wait to do any sort of refactoring until after the semantic conventions SIG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR spec:resource Related to the specification/resource directory
Projects
None yet
Development

No branches or pull requests

3 participants