-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename net.protocol.*, net.sock.family and net.transport attributes to align with ECS #3371
Comments
This is now decided that we will align with the ECS attributes, IIUC. From the OTEP:
These fields seem to map 1-to-1 so I don't see any reason why we shouldn't go ahead with this. |
A quick search show that only Java instrumentation is using
|
There are also the I'm not aware of any OpenTelemetry instrumentation that has implemented the @AlexanderWert is there anything on the ECS side similar to the OpenTelemetry |
I'd like to proprose that we move forward with this rename
|
net.sock.family -> network.type: This sounds different from net.transport. It sounds like it would be set to LTE or Ethernet, etc (something currently stored in net.host.connection.type). Can we come up with a better name (network.sock_family)?
Is this a good enough argument? We could add any missing pieces to our OTel conventions instead
This one is still not merged... |
ya, this is a good point, we should definitely consider this 👍
the argument here is that renaming |
I think OTel's
So, as those are describing different things, how about having both ( Regarding the name |
@Oberon00 @lmolkova do you think we need both at this point? and is it reasonable to consolidate on |
I've split the "socket family" vs OSI layer 3 "network type" discussion out into a separate issue: #3438 |
What are you trying to achieve?
Rename these remaining
net.*
attributes (the ones not covered in #3199) to align with ECS:net.protocol.name
->network.protocol.name
net.protocol.version
->network.protocol.version
net.sock.family
->network.type
net.transport
->network.transport
Unlike the other ECS alignment proposals where we see benefits to the ECS modeling/naming, there's not really any good argument why OTel or ECS attributes are better here.
And so the question remains whether we should align going foward with the existing OpenTelemetry attributes or align with the existing ECS attributes.
The text was updated successfully, but these errors were encountered: