Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming consistency: "length" vs "size" vs "bytes" when for payload size #3439

Closed
trask opened this issue Apr 25, 2023 · 2 comments · Fixed by #3355
Closed

Naming consistency: "length" vs "size" vs "bytes" when for payload size #3439

trask opened this issue Apr 25, 2023 · 2 comments · Fixed by #3355
Assignees
Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:trace Related to the specification/trace directory

Comments

@trask
Copy link
Member

trask commented Apr 25, 2023

Sometimes length is used:

  • http.request_content_length
  • http.response_content_length

Sometimes size is used:

  • message.compressed_size
  • message.uncompressed_size
  • http.server.request.size (metric)
  • http.server.response.size (metric)
  • http.client.request.size (metric)
  • http.client.response.size (metric)

Sometimes size_bytes is used:

  • messaging.message.payload_compressed_size_bytes
  • messaging.message.payload_size_bytes

ECS uses bytes

  • http.request.body.bytes
  • http.response.body.bytes

size makes the most sense to me personally, as bytes seems like it could be the actual bytes.

@trask trask added area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory semconv:HTTP labels Apr 25, 2023
@lmolkova
Copy link
Contributor

related: #1053

@trask
Copy link
Member Author

trask commented Apr 26, 2023

it looks like .size is a pretty good option given some existing ECS attributes are using it as well:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:trace Related to the specification/trace directory
Projects
3 participants