Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where to capture HTTP forwarded proto (original url.scheme)? #3442

Closed
trask opened this issue Apr 25, 2023 · 1 comment · Fixed by open-telemetry/semantic-conventions#376
Closed
Assignees
Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:trace Related to the specification/trace directory

Comments

@trask
Copy link
Member

trask commented Apr 25, 2023

Forwarded header provide a way to get the original url.schema that was used on the client side.

This is useful data, because often TLS is terminated before it reaches the application server, and so the SERVER span on the application server reports url.scheme of http (unsecured), which can cause users to worry that their traffic is unencrypted.

In #3402 we are now proposing to capture the ip (and optional port) from Forwarded into client.address (and client.port).

It would be nice to capture the proto field (original url.scheme) somewhere at the same time, so that we don't need to re-parse the Forwarded header for it later.

@trask trask added area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory semconv:HTTP labels Apr 25, 2023
@trask trask assigned trask and unassigned jmacd Apr 25, 2023
@trask trask changed the title Where to capture original url scheme? Where to capture HTTP forwarded proto (original url.scheme)? Apr 25, 2023
@AlexanderWert
Copy link
Member

It would be nice to capture the proto field (original url.scheme) somewhere at the same time, so that we don't need to re-parse the Forwarded header for it later.

How about a new field url.original.scheme (or url.scheme.original). The url.* namespace seems to be a good place for this information since the Forwarded proto describes an aspect of a URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:trace Related to the specification/trace directory
Projects
3 participants