Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add process.runtime.jvm.cpu.time metric #3490

Closed
trask opened this issue May 9, 2023 · 1 comment · Fixed by open-telemetry/semantic-conventions#55
Closed

Add process.runtime.jvm.cpu.time metric #3490

trask opened this issue May 9, 2023 · 1 comment · Fixed by open-telemetry/semantic-conventions#55
Assignees
Labels
area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory

Comments

@trask
Copy link
Member

trask commented May 9, 2023

We have debated whether to reuse process.cpu.time, and we are currently leaning towards introducing process.runtime.jvm.cpu.time, primarily in order to avoid issues and confusion when process.cpu.time is also captured by the collector.

Even though the "instrumentation scope" and resource attributes will be different when process.cpu.time is captured by the collector:

  • it is still the same thing being observed from two different sources, which could lead to confusion
  • aggregating across both process.cpu.time emitted by the collector and process.cpu.time emitted by the JVM would end up double counting CPU usage
  • some backends may (accidentally) try to merge these
  • some UIs may not make this distinction clear, e.g. when trying to show runtime metrics and associated collector process metrics at the same time

process.runtime.jvm.cpu.time has the added benefit of being clear that this is the CPU time that is reported by the JVM (we aren't scraping metrics from the O/S).

@trask trask added spec:metrics Related to the specification/metrics directory area:semantic-conventions Related to semantic conventions labels May 9, 2023
@jack-berg
Copy link
Member

Only concern is that this is setting a precedent to define new metrics rather than reusing existing ones even when same semantics can be achieved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory
Projects
Development

Successfully merging a pull request may close this issue.

3 participants