Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expo-histograms: Zero Threshold configurability. #3603

Open
MadVikingGod opened this issue Jul 17, 2023 · 1 comment
Open

Expo-histograms: Zero Threshold configurability. #3603

MadVikingGod opened this issue Jul 17, 2023 · 1 comment
Labels
area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory triage:deciding:community-feedback

Comments

@MadVikingGod
Copy link
Contributor

What are you trying to achieve?

Is the Metric SDK intended to configure the zero thresholds of Exponential Histograms?

Additional context.

Currently, there are references to the zero thresholds in the Data-Model and in the otlp Protocol , but none in the SDK or API docs.
If this is left unset or set to 0.0, the SDKs would only respect 0.0 or 0 as a zero value, and only external producers could affect this value in the otlp output.

This was raised when implementing the exponential histograms in go: open-telemetry/opentelemetry-go#4245 (comment)

@MadVikingGod MadVikingGod added the spec:metrics Related to the specification/metrics directory label Jul 17, 2023
@jack-berg
Copy link
Member

Some old conversation about this here.

To summarize roughly, SDKs should default the zero threshold to zero and round all subnormal values to zero:

When zero_threshold is unset or 0, this bucket stores values that cannot be expressed using the standard exponential formula as well as values that have been rounded to zero.

We discussed making it a configurable parameter of the exponential histogram aggregation as being a natural next step, but to my knowledge, nobody has asked for it until this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory triage:deciding:community-feedback
Projects
None yet
Development

No branches or pull requests

5 participants