Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS certificate reloading in SDK #4247

Open
pavolloffay opened this issue Oct 8, 2024 · 3 comments
Open

TLS certificate reloading in SDK #4247

pavolloffay opened this issue Oct 8, 2024 · 3 comments
Labels
spec:miscellaneous For issues that don't match any other spec label triage:deciding:community-feedback Open to community discussion. If the community can provide sufficient reasoning, it may be accepted

Comments

@pavolloffay
Copy link
Member

pavolloffay commented Oct 8, 2024

What are you trying to achieve?

I would like to configure OpenTelemetry SDK to reload TLS certificate.

The OTEL operator community is working on enabling TLS in auto-instrumentations (which use SDKs) open-telemetry/opentelemetry-operator#2997. The operator will inject certificates from a secret (e.g. provisioned by cert-manager). The cert-manager allows rotating certificates automatically, however SDKs don't reload the certificates.

The collector already supports this functionality: reload_interval https://github.com/open-telemetry/opentelemetry-collector/blob/main/config/configtls/README.md

What did you expect to see?

Additional context.

Use-case was rejected in Java SDK open-telemetry/opentelemetry-java#4725

@pavolloffay pavolloffay added the spec:miscellaneous For issues that don't match any other spec label label Oct 8, 2024
@reyang
Copy link
Member

reyang commented Oct 8, 2024

Would you clarify if this is about OTLP exporter or something else? I understand that the solution might be generally applicable to other exporters such as Jaeger/Zipkin, I think we need to have more clarity regarding what's expected here.

@pavolloffay
Copy link
Member Author

I would scope this only for OTLP exporter https://opentelemetry.io/docs/specs/otel/protocol/exporter/

This feature could introduce a new env var OTEL_EXPORTER_OTLP_CERTIFICATE_RELOAD_INTERVAL

@svrnm svrnm added the triage:deciding:community-feedback Open to community discussion. If the community can provide sufficient reasoning, it may be accepted label Oct 14, 2024
@jpkrohling
Copy link
Member

IIRC, the Collector also watches the file system for changes to those specific files. In any case, I think this can certainly be an optional part of the spec, defined based on the current of the collector, which has incorporated some lessons learned already.

@github-actions github-actions bot added the triage:followup Needs follow up during triage label Oct 29, 2024
@trask trask removed the triage:followup Needs follow up during triage label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:miscellaneous For issues that don't match any other spec label triage:deciding:community-feedback Open to community discussion. If the community can provide sufficient reasoning, it may be accepted
Projects
None yet
Development

No branches or pull requests

5 participants