Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SeverityNumber as required parameter in EmitEvent #4261

Open
pellared opened this issue Oct 15, 2024 · 2 comments
Open

SeverityNumber as required parameter in EmitEvent #4261

pellared opened this issue Oct 15, 2024 · 2 comments
Labels
area:api Cross language API specification issue sig-issue A specific SIG should look into this before discussing at the spec spec:logs Related to the specification/logs directory

Comments

@pellared
Copy link
Member

pellared commented Oct 15, 2024

I have a feeling that all Events should have SeverityNumber set to a specified value.

Originally posted by @pellared in #4259 (comment)

Setting the severity is crucial to support the most common way of filtering - by severity level.

Related to:

@pellared pellared added area:api Cross language API specification issue spec:logs Related to the specification/logs directory labels Oct 15, 2024
@trask trask added the sig-issue A specific SIG should look into this before discussing at the spec label Oct 15, 2024
@pellared pellared moved this to Todo in Logs SIG Oct 16, 2024
@pellared
Copy link
Member Author

SIG meeting notes:
@tedsuo finds that it should not be required and that INFO (8?) should be the default value is unspecified. Ted is against the proposal to make it required, or set it by the SDK, or use a default value for a parameter in the API if a language has such option. He stated that 0 should be handled as INFO.

@pellared
Copy link
Member Author

pellared commented Nov 22, 2024

I think that the proposal to handle 0 as INFO is not acceptable change for https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/data-model.md#field-severitynumber as 0 is seen as an unspecified/undefined/invalid value e.g.

Also it would not look nice given the definition:

Smaller numerical values correspond to less severe events (such as debug events), larger numerical values correspond to more severe events (such as errors and critical events).

I propose that the API MUST default SeverityNumber to INFO(8) or make it required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Cross language API specification issue sig-issue A specific SIG should look into this before discussing at the spec spec:logs Related to the specification/logs directory
Projects
Status: Todo
Development

No branches or pull requests

2 participants