-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How should other forms of trace/span ids be handled? #525
Comments
64 bit is "easy", pad with zeroes. I think any other forms of span-IDs are not really supported by OpenTelemetry, which I think is a shame but difficult to change now. I recommend you to read open-telemetry/oteps#58 "Unseal SpanContext" and in particular open-telemetry/oteps#58 (comment):
-- @bogdandrutu |
Or truncate in the case of 128-bit trace IDs? |
OpenTelemetry does use 128 bit trace IDs. 128 bit Span IDs on the other hand would be a problem. You can shoehorn them in the tracestate however. |
Sorry, I meant I need to truncate OpenTelemetry trace IDs (128-bit) when exporting to Datadog (64-bit). I suppose I could add an attribute I don't see anything necessarily wrong with this; just posting here in case I'm getting it wrong. |
That is not possible in statically typed languages like Java (again, see open-telemetry/oteps#58) and I think that is indeed a problem and may become a serious bottleneck of flexibility for vendors wanting to support the API. |
I feel like with the OTEP 66 Context API there is an opportunity to elegantly rectify this by removing the whole SpanContext from the API and hiding it away in the context. See
EDIT: And the often-mentioned OTEP66: https://github.com/open-telemetry/oteps/blob/master/text/0066-separate-context-propagation.md "Context Propagation: A Layered Approach" (open-telemetry/oteps#66) by @tedsuo, recently mostly driven by @carlosalberto |
Hi! I see this has the after-ga label. But I think if we have this after-ga, we may as well close it as "wontfix", because I feel like this would be a breaking change. @carlosalberto |
@Oberon00 So your take is that we should try to work on this before GA instead? |
I'm not sure. I think we could make the decision not to support this. Otherwise it would be a pretty fundamental change. |
Is this still something that is being thought on? I've noticed that DD uses the last 64 bits from the 128 bits OTel uses. |
In OpenTracing, there was no requirement for trace and span ids. It was chosen by the tracer implementation.
For example, Datadog uses 64-bit integers as span and trace ids.
Any preferences/ideas for working with backends that use different ids from OpenTelemetry?
The text was updated successfully, but these errors were encountered: