Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueObserver should use LastValue aggregation by default #945

Closed
nilebox opened this issue Sep 14, 2020 · 1 comment
Closed

ValueObserver should use LastValue aggregation by default #945

nilebox opened this issue Sep 14, 2020 · 1 comment
Labels
area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory

Comments

@nilebox
Copy link
Member

nilebox commented Sep 14, 2020

What are you trying to achieve?
According to the comment #636 (comment), the agreement is to use LastValue aggregation for ValueObserver.
The specification still states that ValueObserver should have MinMaxSumCount aggregation by default: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/metrics/api.md#aggregations

The non-additive instruments (ValueRecorder, ValueObserver) use a MinMaxSumCount aggregation, by default.

What did you expect to see?

Additional context.

Code change in Go SDK switching to LastValue: open-telemetry/opentelemetry-go#1165, needs to be made in other languages as well, but first we need to update the spec.

@nilebox nilebox added the spec:metrics Related to the specification/metrics directory label Sep 14, 2020
@nilebox
Copy link
Member Author

nilebox commented Sep 14, 2020

Closing as duplicate of #834

@nilebox nilebox closed this as completed Sep 14, 2020
@Oberon00 Oberon00 added the area:sdk Related to the SDK label Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

No branches or pull requests

2 participants