From 900e9c97b43e20b4bd56d8497c5d5fc5ee557512 Mon Sep 17 00:00:00 2001 From: Trask Stalnaker Date: Mon, 28 Feb 2022 12:50:36 -0800 Subject: [PATCH 1/2] Add system metrics clarification around containers --- specification/metrics/semantic_conventions/system-metrics.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/specification/metrics/semantic_conventions/system-metrics.md b/specification/metrics/semantic_conventions/system-metrics.md index 11b97442e6d..5841f094640 100644 --- a/specification/metrics/semantic_conventions/system-metrics.md +++ b/specification/metrics/semantic_conventions/system-metrics.md @@ -7,6 +7,10 @@ metrics in OpenTelemetry. Consider the [general metric semantic conventions](README.md#general-metric-semantic-conventions) when creating instruments not explicitly defined in the specification. +When reporting `system.*` metrics from inside a container, they SHOULD be +container metrics and not host metrics, unless the resource attributes +specifically describe the host. + From 357c94d0f362905c0575aa342ca41ebc28fae726 Mon Sep 17 00:00:00 2001 From: Trask Stalnaker Date: Tue, 1 Mar 2022 09:26:46 -0800 Subject: [PATCH 2/2] Update specification/metrics/semantic_conventions/system-metrics.md Co-authored-by: Armin Ruech --- specification/metrics/semantic_conventions/system-metrics.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/metrics/semantic_conventions/system-metrics.md b/specification/metrics/semantic_conventions/system-metrics.md index 5841f094640..16611347908 100644 --- a/specification/metrics/semantic_conventions/system-metrics.md +++ b/specification/metrics/semantic_conventions/system-metrics.md @@ -8,7 +8,7 @@ conventions](README.md#general-metric-semantic-conventions) when creating instruments not explicitly defined in the specification. When reporting `system.*` metrics from inside a container, they SHOULD be -container metrics and not host metrics, unless the resource attributes +reported for the container and not the host, unless the resource attributes specifically describe the host.