From fef35e63134a68a5a6dd611315ed6b0618703c91 Mon Sep 17 00:00:00 2001 From: Jack Berg Date: Wed, 6 Jul 2022 12:30:09 -0500 Subject: [PATCH 1/4] Add JVM buffer pool semantic conventions --- .../semantic_conventions/runtime-environment-metrics.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/specification/metrics/semantic_conventions/runtime-environment-metrics.md b/specification/metrics/semantic_conventions/runtime-environment-metrics.md index fe3ff204e85..5481f423c15 100644 --- a/specification/metrics/semantic_conventions/runtime-environment-metrics.md +++ b/specification/metrics/semantic_conventions/runtime-environment-metrics.md @@ -78,7 +78,11 @@ All JVM metric attributes are required unless otherwise indicated. | process.runtime.jvm.cpu.utilization | Recent cpu utilization for the process [2] | 1 | 1 | Asynchronous Gauge | Double | | | | process.runtime.jvm.system.cpu.utilization | Recent cpu utilization for the whole system [2] | 1 | 1 | Asynchronous Gauge | Double | | | | process.runtime.jvm.system.cpu.load_1m | Average CPU load of the whole system for the last minute | 1 | 1 | Asynchronous Gauge | Double | | | +| process.runtime.jvm.buffer.usage | Measure of memory used by buffers | Bytes | `By` | UpDownCounter | Int64 | pool | Name of pool[3] | +| process.runtime.jvm.buffer.limit | Measure of total memory capacity of buffers | Bytes | `By` | UpDownCounter | Int64 | pool | Name of pool[3] | +| process.runtime.jvm.buffer.count | Number of buffers in the pool | buffers | `{buffers}}` | UpDownCounter | Int64 | pool | Name of pool[3] | **[1]**: Pool names are generally obtained via [MemoryPoolMXBean#getName()](https://docs.oracle.com/en/java/javase/11/docs/api/java.management/java/lang/management/MemoryPoolMXBean.html#getName()). Examples include `G1 Old Gen`, `G1 Eden space`, `G1 Survivor Space`, `Metaspace`, etc. **[2]**: These utilizations are not defined as being for the specific interval since last measurement (unlike `system.cpu.utilization`). +**[3]**: Pool names are generally obtained via [BufferPoolMXBean#getName()](https://docs.oracle.com/en/java/javase/11/docs/api/java.management/java/lang/management/BufferPoolMXBean.html#getName()). From 1a3b118f9fffdc6ff955df5e505a9fe2331352b5 Mon Sep 17 00:00:00 2001 From: Jack Berg Date: Wed, 6 Jul 2022 12:33:06 -0500 Subject: [PATCH 2/4] Add changelog entry --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7752515b01b..f959f86c40d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -47,6 +47,8 @@ release. - Add `http.*.*.size` metric semantic conventions for tracking size of requests / responses for http servers / clients ([#2588](https://github.com/open-telemetry/opentelemetry-specification/pull/2588)). +- Add semantic conventions for JVM buffer pool usage + ([#2650](https://github.com/open-telemetry/opentelemetry-specification/pull/2650)). ### Compatibility From e30a6f31078e4410df134380377315a6e331c4e0 Mon Sep 17 00:00:00 2001 From: Joshua MacDonald Date: Fri, 8 Jul 2022 16:26:35 -0700 Subject: [PATCH 3/4] Update specification/metrics/semantic_conventions/runtime-environment-metrics.md Co-authored-by: Trask Stalnaker --- .../metrics/semantic_conventions/runtime-environment-metrics.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/metrics/semantic_conventions/runtime-environment-metrics.md b/specification/metrics/semantic_conventions/runtime-environment-metrics.md index 5481f423c15..05f8d176e2a 100644 --- a/specification/metrics/semantic_conventions/runtime-environment-metrics.md +++ b/specification/metrics/semantic_conventions/runtime-environment-metrics.md @@ -80,7 +80,7 @@ All JVM metric attributes are required unless otherwise indicated. | process.runtime.jvm.system.cpu.load_1m | Average CPU load of the whole system for the last minute | 1 | 1 | Asynchronous Gauge | Double | | | | process.runtime.jvm.buffer.usage | Measure of memory used by buffers | Bytes | `By` | UpDownCounter | Int64 | pool | Name of pool[3] | | process.runtime.jvm.buffer.limit | Measure of total memory capacity of buffers | Bytes | `By` | UpDownCounter | Int64 | pool | Name of pool[3] | -| process.runtime.jvm.buffer.count | Number of buffers in the pool | buffers | `{buffers}}` | UpDownCounter | Int64 | pool | Name of pool[3] | +| process.runtime.jvm.buffer.count | Number of buffers in the pool | buffers | `{buffers}` | UpDownCounter | Int64 | pool | Name of pool[3] | **[1]**: Pool names are generally obtained via [MemoryPoolMXBean#getName()](https://docs.oracle.com/en/java/javase/11/docs/api/java.management/java/lang/management/MemoryPoolMXBean.html#getName()). Examples include `G1 Old Gen`, `G1 Eden space`, `G1 Survivor Space`, `Metaspace`, etc. From 5195f0e6b9cb804cff275dc42198ebfb7d2445c8 Mon Sep 17 00:00:00 2001 From: Reiley Yang Date: Wed, 13 Jul 2022 09:55:47 -0700 Subject: [PATCH 4/4] Update specification/metrics/semantic_conventions/runtime-environment-metrics.md Co-authored-by: Armin Ruech --- .../metrics/semantic_conventions/runtime-environment-metrics.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/metrics/semantic_conventions/runtime-environment-metrics.md b/specification/metrics/semantic_conventions/runtime-environment-metrics.md index 05f8d176e2a..3b2ba46cc03 100644 --- a/specification/metrics/semantic_conventions/runtime-environment-metrics.md +++ b/specification/metrics/semantic_conventions/runtime-environment-metrics.md @@ -80,7 +80,7 @@ All JVM metric attributes are required unless otherwise indicated. | process.runtime.jvm.system.cpu.load_1m | Average CPU load of the whole system for the last minute | 1 | 1 | Asynchronous Gauge | Double | | | | process.runtime.jvm.buffer.usage | Measure of memory used by buffers | Bytes | `By` | UpDownCounter | Int64 | pool | Name of pool[3] | | process.runtime.jvm.buffer.limit | Measure of total memory capacity of buffers | Bytes | `By` | UpDownCounter | Int64 | pool | Name of pool[3] | -| process.runtime.jvm.buffer.count | Number of buffers in the pool | buffers | `{buffers}` | UpDownCounter | Int64 | pool | Name of pool[3] | +| process.runtime.jvm.buffer.count | Number of buffers in the pool | buffers | `{buffers}` | UpDownCounter | Int64 | pool | Name of pool[3] | **[1]**: Pool names are generally obtained via [MemoryPoolMXBean#getName()](https://docs.oracle.com/en/java/javase/11/docs/api/java.management/java/lang/management/MemoryPoolMXBean.html#getName()). Examples include `G1 Old Gen`, `G1 Eden space`, `G1 Survivor Space`, `Metaspace`, etc.