From 46a4ab1a6620f3ba91187f4769ad5c3ca7401cdb Mon Sep 17 00:00:00 2001 From: Tyler Yahn Date: Thu, 31 Aug 2023 08:29:19 -0700 Subject: [PATCH 1/2] Clarify `attribute_keys` min impl is allow-list Additional filtering functionality is allowed for this parameter. --- specification/metrics/sdk.md | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/specification/metrics/sdk.md b/specification/metrics/sdk.md index b51ce4f9328..d576fc09181 100644 --- a/specification/metrics/sdk.md +++ b/specification/metrics/sdk.md @@ -314,9 +314,13 @@ The SDK MUST accept the following stream configuration parameters: accept a `description`, but MUST NOT obligate a user to provide one. If the user does not provide a `description` value, the description from the Instrument a View matches MUST be used by default. -* `attribute_keys`: A list of attribute keys that MUST be kept, if provided by - the user during the measurement, for the metric stream. All attributes with - keys other than those in the list MUST be ignored. +* `attribute_keys`: This is, at a minimum, an allow-list of attribute keys for + measurements captured in the metric stream. The allow-list contains attribute + keys that identify the attributes that MUST be kept, and all other attributes + MUST be ignored. + + Implementations MAY accept additional attribute filtering functionality for + this parameter. Users can provide `attribute_keys`, but it is up to their discretion. Therefore, the stream configuration parameter needs to be structured to From 1591f083d22f6b0efc94517068f2fc4b5b8e09f9 Mon Sep 17 00:00:00 2001 From: Tyler Yahn Date: Thu, 31 Aug 2023 08:32:05 -0700 Subject: [PATCH 2/2] Add a changelog entry --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index cc5505f87e7..787467e204c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,6 +27,8 @@ release. ([#3670](https://github.com/open-telemetry/opentelemetry-specification/pull/3670)) - Rename "advice" to "advisory parameters". ([#3662](https://github.com/open-telemetry/opentelemetry-specification/pull/3662)) +- Clarify the minimal implementation of a `View`'s `attribute_keys` is an allow-list. + ([#3680](https://github.com/open-telemetry/opentelemetry-specification/pull/3680)) ### Logs