From 0f84c556995469841121c801fbbbfc11d72cdbbb Mon Sep 17 00:00:00 2001 From: jwatson Date: Mon, 20 Apr 2020 13:24:52 -0700 Subject: [PATCH 1/3] Add the requirement for the probability sampler to include a span attribute describing its probability. --- specification/trace/sdk.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/specification/trace/sdk.md b/specification/trace/sdk.md index 4a361033eaf..747f553c765 100644 --- a/specification/trace/sdk.md +++ b/specification/trace/sdk.md @@ -119,6 +119,9 @@ These are the default samplers implemented in the OpenTelemetry SDK: that are root spans (no parent) and Spans with remote parent. However there should be configuration to change this to "root spans only", or "all spans". * Description MUST be `ProbabilitySampler{0.000100}`. + * If the probability is applied (as opposed to using the parent's `SampledFlag` value), the set of span Attributes + returned in the result MUST be a single attribute with the key `sampling.probability` and a value of the probability + being used. #### Probability Sampler algorithm From e833c3c81a636a1634b17d39c5717c2f5f177896 Mon Sep 17 00:00:00 2001 From: John Watson Date: Tue, 21 Apr 2020 08:04:54 -0700 Subject: [PATCH 2/3] Update specification/trace/sdk.md Co-Authored-By: Armin Ruech --- specification/trace/sdk.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/trace/sdk.md b/specification/trace/sdk.md index 747f553c765..29942987ff6 100644 --- a/specification/trace/sdk.md +++ b/specification/trace/sdk.md @@ -120,7 +120,7 @@ These are the default samplers implemented in the OpenTelemetry SDK: should be configuration to change this to "root spans only", or "all spans". * Description MUST be `ProbabilitySampler{0.000100}`. * If the probability is applied (as opposed to using the parent's `SampledFlag` value), the set of span Attributes - returned in the result MUST be a single attribute with the key `sampling.probability` and a value of the probability + returned in the result MUST include an attribute with the key `sampling.probability` and a value of the probability being used. #### Probability Sampler algorithm From efb73763c63ff5a2e14e7f30735509f3139c82bd Mon Sep 17 00:00:00 2001 From: jwatson Date: Tue, 21 Apr 2020 08:28:39 -0700 Subject: [PATCH 3/3] shorten line lengths to 80 --- specification/trace/sdk.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/specification/trace/sdk.md b/specification/trace/sdk.md index 29942987ff6..ba8b00a6abd 100644 --- a/specification/trace/sdk.md +++ b/specification/trace/sdk.md @@ -119,9 +119,10 @@ These are the default samplers implemented in the OpenTelemetry SDK: that are root spans (no parent) and Spans with remote parent. However there should be configuration to change this to "root spans only", or "all spans". * Description MUST be `ProbabilitySampler{0.000100}`. - * If the probability is applied (as opposed to using the parent's `SampledFlag` value), the set of span Attributes - returned in the result MUST include an attribute with the key `sampling.probability` and a value of the probability - being used. + * If the probability is applied (as opposed to using the parent's + `SampledFlag` value), the set of span Attributes returned in the result MUST + include an attribute with the key `sampling.probability` and a value of the + probability being used. #### Probability Sampler algorithm