Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the requirement for the probability sampler #570

Closed
wants to merge 3 commits into from
+4 −0
Closed

Add the requirement for the probability sampler #570

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f84c55
Add the requirement for the probability sampler to include a span att…
Apr 20, 2020
e833c3c
Update specification/trace/sdk.md
jkwatson Apr 21, 2020
efb7376
shorten line lengths to 80
Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions specification/trace/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ These are the default samplers implemented in the OpenTelemetry SDK:
that are root spans (no parent) and Spans with remote parent. However there
should be configuration to change this to "root spans only", or "all spans".
* Description MUST be `ProbabilitySampler{0.000100}`.
* If the probability is applied (as opposed to using the parent's `SampledFlag` value), the set of span Attributes
returned in the result MUST be a single attribute with the key `sampling.probability` and a value of the probability
jkwatson marked this conversation as resolved.
Show resolved Hide resolved
being used.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Jaeger clients the samplers return two tags (at minimum), indicating the type of sampler used, and the parameter value (like probability, or rate for rate limiting sampler). It's functionally equivalent, but makes it easier to determine the type of sampler used than matching on potentially different tag names (e.g. Jaeger collector adds sampler type as a label on the metric of how many traces it receives).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be all in favor of having the Decision include the sampler name, as well. I think that's a different PR than this one, though. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this very similar to the component=http attribute, which we decided against?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a little different to me. This is an internal detail of the sampling itself, rather than something that is coming from outside the sampler (like the component).


#### Probability Sampler algorithm

Expand Down