Metric API v0.4 specification #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
April 29, 2020 17:14
jmacd
added
area:api
jmacd
pushed a commit
to jmacd/opentelemetry-specification
that referenced
this pull request
May 5, 2020
jmacd
requested review from
arminru,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
cijothomas
reviewed
May 7, 2020
cijothomas
reviewed
May 7, 2020
cijothomas
reviewed
May 7, 2020
cijothomas
reviewed
May 7, 2020
cijothomas
reviewed
May 7, 2020
|
As discussed in the SIG call today, if the feedback is about something minor, please consider leaving your comments with approval. I'll be sure to address all the comments, but this way you can stop paying attention. I'd like to merge this by the end of the week if no substantial problems are found. |
jkwatson
approved these changes
May 7, 2020
cijothomas
approved these changes
May 7, 2020
bogdandrutu
approved these changes
May 8, 2020
|
Please rebase to fix links issues |
|
I've addressed the remaining issues. Thanks! |
|
It's worth noting that this has 4 approvals from the proposed set of metrics approvers. |
carlosalberto
approved these changes
May 8, 2020
|
Not a metrics approver but approving to help this PR get merged. |
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Rewrite the intro * Edit labels section * Aggregations update * Time update * Three categories * 6 kinds * Section on memory requirements * Update links to in-progress work * Update TOC * Reorder and update TOC * Restore some text * Restore the TODO code * Restore api-user.md; for a separate PR * Feedback round 1 * New pargraph * Lint * Remove six * Remove the other two documents as out-of-date * Update links; TODOs about api-user.md content lost * Be consistent about distributed context and request * Define Additive * Remove refs to api-user.md * Clarify that monotonics are additive * Monotonic comment about rates * Feedback * SPI note * Typos * on correlation values * remove content on memory requirements, it's SDK stuff * Remove a dead link * Update TOC * Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main API specification document (api.md) is ready for review in this PR. This document is up-to-date with respect to OTEP 98, which is expected to merge without further modification (explanation).
The accompanying user-level specification document (api-user.md) is in draft form, not ready for review in #582.