Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss using http.request.* and http.response.* #99

Closed
danielkhan opened this issue Jun 11, 2019 · 2 comments
Closed

Discuss using http.request.* and http.response.* #99

danielkhan opened this issue Jun 11, 2019 · 2 comments
Labels
area:semantic-conventions Related to semantic conventions

Comments

@danielkhan
Copy link
Contributor

For HTTP we often have to distinguish between request and response which leads to long field names like http.requestheaders and http.responseheaders.

So instead of using http.requestheaders it could be http.request.headers, http.response.headers.

This might be also applicable to other protocols.

ECS does something similar https://github.com/elastic/ecs/blob/master/schemas/http.yml

@SergeyKanzhelev SergeyKanzhelev added this to the API revision: 07-2019 milestone Jun 20, 2019
@iredelmeier iredelmeier added the area:semantic-conventions Related to semantic conventions label Jul 30, 2019
@SergeyKanzhelev SergeyKanzhelev modified the milestones: API revision: 07-2019, Alpha v0.3 Sep 27, 2019
@Oberon00
Copy link
Member

Oberon00 commented Oct 1, 2019

For HTTP we often have to distinguish between request and response

This is done via the Span Kind, not the attribute names.

Headers cannot really be transported with the current restriction that attributes must be scalars (unless you use a convention like htpp.response.header.<HEADERNAME>). It is a bit unclear what this issue is about: Introduce semantic conventions for headers?

@jmacd jmacd removed this from the Alpha v0.3 milestone Jan 22, 2020
@jmacd
Copy link
Contributor

jmacd commented Jan 22, 2020

Closing this as there are no semantic conventions for request and response headers. Please reopen if you think we should have semantic conventions for request and response headers at this time, or submit a PR to the spec.

@jmacd jmacd closed this as completed Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions
Projects
None yet
Development

No branches or pull requests

5 participants