Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using Docy's tabbed panes #1820

Closed
3 tasks done
chalin opened this issue Oct 6, 2022 · 4 comments · Fixed by #2544
Closed
3 tasks done

Switch to using Docy's tabbed panes #1820

chalin opened this issue Oct 6, 2022 · 4 comments · Fixed by #2544

Comments

@chalin
Copy link
Contributor

chalin commented Oct 6, 2022

Docy has a flexible implementation of tabbed panes that, for example supports both code and text in a tab. I suggest that we drop our own custom implementation of tabs and upgrade to Docsy's.

WDYT @svrnm @cartermp @austinlparker? I'd like your thumbs up before I start on this cleanup.

We only have about 4 files so the upgrade wouldn't be too painful, but more files are being updated (e.g., #1800) to use tabs, so if we're going to do this I think it would be better sooner than latter :).

Tasks:

Related:

@cartermp
Copy link
Contributor

cartermp commented Oct 7, 2022

Yes, please! This would allow for use of rewrap on the relevant files if code moves to code blocks.

@svrnm
Copy link
Member

svrnm commented Oct 7, 2022

Yes, let's do that!

@chalin
Copy link
Contributor Author

chalin commented Oct 10, 2022

Great! Ok, I'll start that as soon as I can (and I'll add a comment to #1772) -- I'm waiting on some Docsy updates before proceeding.

@chalin
Copy link
Contributor Author

chalin commented Oct 10, 2022

Some tabs work with the Docsy tab-related shortcodes, but some don't yet. Waiting on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants