Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages with non-trivial but short TOCs don't get displayed #712

Closed
Tracked by #769 ...
chalin opened this issue Sep 8, 2021 · 0 comments · Fixed by #1633
Closed
Tracked by #769 ...

Pages with non-trivial but short TOCs don't get displayed #712

chalin opened this issue Sep 8, 2021 · 0 comments · Fixed by #1633
Labels
CI/infra CI & infrastructure docsy e0-minutes Effort: < 60 min e1-hours Effort: < 8 hrs p2-medium

Comments

@chalin
Copy link
Contributor

chalin commented Sep 8, 2021

The Data sources page has three H2 headings but no TOC is displayed in the right nav:

This is because the current toc.html partial (somewhat arbitrarily IMHO) decides whether it should display the TOC based on the character length of the TOC HTML! We can do better than this: e.g., at least count the number of headings.

Info:

@chalin chalin added CI/infra CI & infrastructure e0-minutes Effort: < 60 min p3-low labels Sep 8, 2021
@chalin chalin added the docsy label Sep 21, 2021
@chalin chalin mentioned this issue Sep 23, 2021
32 tasks
@chalin chalin added p2-medium and removed p3-low labels Oct 22, 2021
@chalin chalin mentioned this issue Jan 13, 2022
6 tasks
@chalin chalin mentioned this issue Apr 2, 2022
24 tasks
@chalin chalin added the e1-hours Effort: < 8 hrs label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure docsy e0-minutes Effort: < 60 min e1-hours Effort: < 8 hrs p2-medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant