-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define guidelines for messaging about excessive amounts of recorded data #1163
Comments
@jtmalinowski since you have a related PR open do you mind if I assign this issue to you? |
@tigrannajaryan please do |
I'm sure @jmacd and @jkwatson had comments on this, and I may be remembering it wrong but @MrAlias I think said something too. Comments from RUM (browser, android, ios) perspective would certainly be very useful too: @obecny (unless you have no opinion or would like to delegate this to someone else), @ivomagi, @johnbley, @alolita. If you have no opinion on this subject, please thumbs down this comment, so I know you saw it, thanks! |
Ideally we could inform user:
|
I went to the messaging WG today to discuss what happens when we reach link limits. There is a default link limit for spans (128), but the GCP Pub/Sub library can publish batches of up to 1000 messages. To work around this, we're using the environment variable to set the link limit. If the user has it set to the default or a lower limit, we capture all of the links by creating "publish #" spans which don't represent new work but are only created to hold all the links. See below the example screenshot When we discussed today, @lmolkova raised two options for solving this problem:
Everyone seems to prefer option 1. |
What are you trying to achieve?
Specify general guidelines for behaviour of SDK libraries in cases when there's excessive/abnormal amount of telemetry data being produced (e.g. a faulty loop produces too many / too long attributes).
2 decisions to be made:
Additional context.
There seem to be a couple of conflicting opinions about how to inform users about data truncation, especially in comments on open-telemetry/opentelemetry-specification#1130.
The text was updated successfully, but these errors were encountered: