Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename http.*.duration metrics to http.*.request.duration #222

Closed
lmolkova opened this issue Jul 31, 2023 · 0 comments · Fixed by #224
Closed

Rename http.*.duration metrics to http.*.request.duration #222

lmolkova opened this issue Jul 31, 2023 · 0 comments · Fixed by #224
Assignees

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Jul 31, 2023

At some point, we might want to report the connection duration, body stream reading duration, or something else in addition to the request duration.

If this happens, we'd regret having ambiguous http.client|server.duration.

Proposal:

  • rename http.client.duration to http.client.request.duration
  • rename http.server.duration to http.server.request.duration

Context: .NET runtime is being instrumented with HTTP metrics and will report both: HTTP connection duration and standard request durations (lmolkova#1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants