-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the difference between a host and a system metric #226
Comments
cc @ChrsMark |
just in case it helps, there was a somewhat related prior discussion here: open-telemetry/opentelemetry-specification#2388 |
Thanks for filing this @frzifus @mx-psi ! I think that we need to decide to only use one namespace for all the related metrics coming from the system/host. Either it is Based on the discussion that @trask indicated, I think that it makes sense to use the |
We had a discussion about this during the August 30th System Semantic Convention WG meeting. The main points were the following:
@mx-psi @dmitryax @kaiyan-sheng @AlexanderWert feel free to correct me if I miss anything here from what we discussed. If we agree on this we can maybe transfer this conclusion somewhere for future reference (and then close this issue). cc: @trask |
Thanks for the summary @ChrsMark! I think there is agreement within the System semantic conventions WG. Given there has not been any disagreement voiced on this issue, I think we can open a PR to put this in writing somewhere: for (1) and (2) maybe on the README.md of the relevant folders on this repository, while I am not sure as to where to put (3) |
Thanks @mx-psi ! I can try to consolidate (1) and (2) in https://github.com/open-telemetry/semantic-conventions/blob/main/docs/resource/host.md and then (2) and (3) (rephrased) in https://github.com/open-telemetry/semantic-conventions/blob/main/docs/system/system-metrics.md. For (2) and (3) we want something similar to https://github.com/open-telemetry/opentelemetry-specification/pull/2388/files#diff-48ed2e166c485f6f64a1a78251b07248e74e9c2a41cfe24e2950b07a5db196b2R10-R13 which was closed. Actually what we propose here is exactly the opposite with the content of that PR but aligns with open-telemetry/opentelemetry-specification#2388 (comment). @trask if you have any suggestions or thoughts on this please let us know :). |
This issue is intended to discuss the difference between the host and system namespace. The outcome should be a clear description of when which ns is used.
This question was raised during the Aug 2, 2023, 08:30 PT SIG MTG and needs to be answered to continue on this PR.
The text was updated successfully, but these errors were encountered: